-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -L option to curl to follow redirect #593
Conversation
to new bootstrap location
Thanks for submitting your first pull request! You are awesome! 🤗 |
This is a minor documentation fix. Not sure how testable that is from an automated perspective. I tested it in AWS, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job spotting this @LTangaF ❤️ and thanks a lot for opening this PR.
Do you mind adding the curl
follow redirect flag to the other places in the docs? (and the integration upgrade test):
I believe this are all the occurrences that should be changed:
I didn't realize there was a test for the documentation changes. It looks like it came up green here without it, which is interesting. I'll work on those other doc changes. |
There isn't any test for doc changes that would error from this. I think the red from my
Thanks a lot for working on this ❤️ |
I updated the integration test as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for going the extra mile and fixing the docs for all the cloud providers ❤️
to new bootstrap location