-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootstrap pip spec to the integration test docs #558
Add bootstrap pip spec to the integration test docs #558
Conversation
As an alternative, we might also want to specify the full bootstrap pip spec instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch @jtpio. I didn't realize the instructions were no longer up to date after updating the tests 😕
Since the bootstrap_pip_spec
arg was added for the upgrade tests, I don't think is of much relevance when running the integration tests. Now thinking, if I'd have made the bootstrap_pip_spec
argument optional, we wouldn't have needed to force people add an empty string in the list of args (which can easily be forgotten) or the entire pip spec of TLJH.
What do you think about making the bootstrap_pip_spec
so that if people want to use it, they would do so with:
--bootrap_pip_spec <some-pip-spec>
And if they just want the default one, they just run the tests as usual, no empty string needed.
Update: Opened #563 with this change
That would be really nice. An empty string is not very explicit and after reading the updated docs again (from this change), it felt a bit odd. An optional parameter sounds good 👍
Great, thanks! I can update this PR to the mention the optional |
8af92e4
to
5f693c2
Compare
Perfect! Just updated the PR and rebased on the latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @jtpio 🌞
Update the docs to run the integration tests locally.
The
bootstrap_pip_spec
parameter can be specified before the test files to avoid shifting the arguments, similar to the Circle CI script:the-littlest-jupyterhub/.circleci/config.yml
Lines 59 to 61 in 01ba348
Add tests