Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clearer that you always need a domain name for HTTPS #217

Closed
yuvipanda opened this issue Oct 29, 2018 · 4 comments · Fixed by #328
Closed

Make it clearer that you always need a domain name for HTTPS #217

yuvipanda opened this issue Oct 29, 2018 · 4 comments · Fixed by #328
Labels
good first issue Good for newcomers help wanted Extra attention is needed needs-documentation Issue that can be solved with documentation

Comments

@yuvipanda
Copy link
Collaborator

HTTPS generally does not work with IP addresses - you need a domain name. Make sure your HTTPS docs make this clear.

From conversation with @mdogy
@choldgraf choldgraf added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 6, 2018
@fm75
Copy link
Contributor

fm75 commented Dec 12, 2018

@yuvipanda
It should be easy enough to explain that you need a domain name that can be reached by DNS. Is it sufficient to add this to docs/howto/admin/https.rst, or does it also need instructions on setting up DNS?

How to set up DNS will be different if access is via the internet, versus doing it on a private network.

Should I not pick this up myself because of the good first issue label?

yuvipanda added a commit to yuvipanda/the-littlest-jupyterhub that referenced this issue May 19, 2019
@yuvipanda
Document that you need a domain name before HTTPS
a569417 
Also note that Let's Encrypt doesn't work in private
networks.

Fixes jupyterhub#217
@yuvipanda yuvipanda mentioned this issue May 19, 2019
Merged
1 task
@yuvipanda
Copy link
Collaborator Author

Apologies for not getting back to this issue for so long! I have documented this as part of #328, hopefully that's clear enough.

@yuvipanda yuvipanda added needs-documentation Issue that can be solved with documentation and removed needs-documentation Issue that can be solved with documentation labels May 20, 2019
@fm75
Copy link
Contributor

fm75 commented May 20, 2019

#328 looks good to me.

@yuvipanda
Copy link
Collaborator Author

Thanks for taking a look, @fm75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed needs-documentation Issue that can be solved with documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup HTTPS documentation yuvipanda/the-littlest-jupyterhub
3 participants
@yuvipanda @choldgraf @fm75