Skip to content

Commit

Permalink
Merge pull request #559 from yuvipanda/feat/upstream-culler
Browse files Browse the repository at this point in the history
Use idle culler from jupyterhub-idle-culler package
  • Loading branch information
consideRatio authored May 4, 2020
2 parents 8d2a1c8 + ed9430e commit a97adcc
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 347 deletions.
2 changes: 1 addition & 1 deletion .circleci/integration-test.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def run_systemd_image(image_name, container_name, bootstrap_pip_spec):
# This is the minimum VM size we support. JupyterLab extensions seem
# to need at least this much RAM to build. Boo?
# If we change this, need to change all other references to this number.
'--memory', '1G',
'--memory', '1.0G',
]

if bootstrap_pip_spec:
Expand Down
6 changes: 3 additions & 3 deletions tests/test_configurer.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def test_cull_service_default():
c = apply_mock_config({})

cull_cmd = [
sys.executable, '-m', 'tljh.cull_idle_servers',
sys.executable, '-m', 'jupyterhub_idle_culler',
'--timeout=600', '--cull-every=60', '--concurrency=5',
'--max-age=0'
]
Expand All @@ -238,7 +238,7 @@ def test_set_cull_service():
}
})
cull_cmd = [
sys.executable, '-m', 'tljh.cull_idle_servers',
sys.executable, '-m', 'jupyterhub_idle_culler',
'--timeout=600', '--cull-every=10', '--concurrency=5',
'--max-age=60', '--cull-users'
]
Expand All @@ -261,7 +261,7 @@ def test_load_secrets(tljh_dir):
c = apply_mock_config(tljh_config)
assert c.TraefikTomlProxy.traefik_api_password == "traefik-password"


def test_auth_native():
"""
Test setting Native Authenticator
Expand Down
2 changes: 1 addition & 1 deletion tljh/configurer.py
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def set_cull_idle_service(config):
Set Idle Culler service
"""
cull_cmd = [
sys.executable, '-m', 'tljh.cull_idle_servers'
sys.executable, '-m', 'jupyterhub_idle_culler'
]
cull_config = config['services']['cull']
print()
Expand Down
342 changes: 0 additions & 342 deletions tljh/cull_idle_servers.py

This file was deleted.

1 change: 1 addition & 0 deletions tljh/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ def ensure_jupyterhub_package(prefix):
'jupyterhub-ldapauthenticator==1.3.0',
'jupyterhub-tmpauthenticator==0.6',
'oauthenticator==0.10.0',
'jupyterhub-idle-culler==1.0'
])
traefik.ensure_traefik_binary(prefix)

Expand Down

0 comments on commit a97adcc

Please sign in to comment.