Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia_project.py: fix Pkg REPL api warning #1376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fonsp
Copy link

@fonsp fonsp commented Oct 28, 2024

Repo2docker currently prints this warning when using a Julia project:

Warning: The Pkg REPL mode is intended for interactive use only, and should not be used from scripts. It is recommended to use the functional API instead.
└ @ Pkg.REPLMode /srv/julia/share/julia/stdlib/v1.10/Pkg/src/REPLMode/REPLMode.jl:382
�[0m  at 12:24:22

This PR fixes that. I also used Pkg.instantiate() instead of Pkg.precompile() because it makes a bit more sense in this context: we want to guarantee that packages are instantiated (which precompiles at the end), not just that they are precompiled: https://pkgdocs.julialang.org/v1/api/#Pkg.instantiate

I believe that resolve already instantiates (and precompiles), but this is not defined in spec so it is good to add the instantiate call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant