Skip to content

Add targetPath to link generator. #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

ryanlovett
Copy link
Contributor

This fixes #326. jupyter-shiny-proxy can look for shiny apps in alternative locations like ~/ShinyApps/. We need our instructors to be able to set this in targetPath via the form.

I tested this by building the docs locally and a JupyterHub link worked for me.

@ryanlovett
Copy link
Contributor Author

@GeorgianaElena @consideRatio @yuvipanda Would it be okay if I merged this myself? I'll wait another week for people to raise any objections.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right from a quick mobile phone look through!

👍 on self-merging this kind of change when review capacity is low. Pinging and waiting is a bit before is a suitable pattern i think.

@consideRatio consideRatio merged commit 5b2df7f into jupyterhub:main Jul 8, 2025
3 checks passed
@ryanlovett
Copy link
Contributor Author

Thanks @consideRatio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve nbgitpuller link generator to include target path options
2 participants