Fix user was added on sign-up even if password didn't match confirmation #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
changed the title
consideRatio
commented
Sep 17, 2024
| password = self.get_body_argument("signup_password", strip=False) | ||
| confirmation = self.get_body_argument( | ||
| "signup_password_confirmation", strip=False | ||
| ) | ||
| confirmation_matches = password == confirmation | ||
| user_is_admin = user_info["username"] in self.authenticator.admin_users |
There was a problem hiding this comment.
user_info wasn't set before if re-captcha had failed (assume_user_is_human=False), so this is fixed now as well.
consideRatio
commented
Sep 17, 2024
Comment on lines
-174
to
-176
| username_already_taken = self.authenticator.user_exists( | ||
| user_info["username"] | ||
| ) |
There was a problem hiding this comment.
This check is now always done which I think is perfectly fine in this case.
31 tasks
minrk
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #271 where I failed to push a commit with fixes needed as seen by @manics.
Thank you @paolocarinci for spotting this and initializing the work to fix it!!