Add icon type description for the icon_path property under ServerProxy.servers
#527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from Backlog
to Done
in PR triage (experimental)
|
Thank you so much for the PR, @chengs! Apologies for the delayed response, we're working on getting better and faster at triage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
IconHandlerjupyter-server-proxy/jupyter_server_proxy/api.py
Line 71 in 8c5906a
Reading the icon file is under text (not binary) mode, thus only text-based icon types are supported
by the
icon_pathproperty.The long-term solution would be fixing the
IconHandlerclass.This PR is a short-team solution, ie, adding description for the
icon_pathmentioning that only text-based(well most of cases, SVG) are supported.