Skip to content

Secure server_data_dir creation with nested temp dir #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Secure server_data_dir creation with nested temp dir #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jupyter_rsession_proxy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ def _get_cmd(port, unix_socket):

# use mkdtemp() so the directory and its contents don't vanish when
# we're out of scope
server_data_dir = tempfile.mkdtemp()
# we create the server_data_dir inside another temp dir,
# as rserver seems to insists on changing its permissions to 777.
# wrapping it in the first tempdir insists the contents of server_data_dir stay secure.
server_data_dir = tempfile.mkdtemp(dir=tempfile.mkdtemp())
database_config_file = db_config(server_data_dir)

cmd = [
Expand Down