Adds support for unix_socket

[jhgoebbert]

This PR enables RStudio connections via sockets in combination with this PR for RStudio rstudio/rstudio#14938

[jhgoebbert]

This PR also

• adds www-thread-pool-size as a possible option which can be set via the environment variable RSERVER_THREAD_POOL_SIZE
• calls rserver just once to get all supported arguments in _support_args(). This is useful as rserver might be only available through modules which takes some time to load. Therefore, this loading can be reduced.

[yuvipanda]

yay, thank you for your contribution both here and upstream to rstudio! This is going to unlock a lot of non-containerized use cases - I'm super excited for that to land :)

If you could split the PR into a unix socket one and one with everything else, that would make this easier to review and merge. I would like to hold off on merging the unix socket one until that upstream PR gets merged, but the others should be easier. Would you be open to splitting it up like that?

Thanks!

[jhgoebbert]

Thanks @yuvipanda . I will split the PR.

The PR for unix-socket support in RStudio is now merged and will be part of the official "Kousa Dogwood" builds expected in 2024.10 : rstudio/rstudio#14938 (comment)

[benz0li]

RStudio v2024.12.0+467 is out: https://github.com/rstudio/rstudio/releases/tag/v2024.12.0%2B467

[benz0li]

I would like to hold off on merging the unix socket one until that upstream PR gets merged, but the others should be easier. Would you be open to splitting it up like that?

@jhgoebbert Could you split the PR into a unix socket one and one with everything else?

Thank you.

[benz0li]

@yuvipanda Or could this be merged as is?

@consideRatio Any objections?

[benz0li]

I tested this PR successfully with RStudio v2024.12.0+467 and

pip install git+https://github.com/jhgoebbert/jupyter-rsession-proxy@feature/sockets

plus setting environment variable RSERVER_USE_SOCKET=1.

[benz0li]

@jhgoebbert @yuvipanda @consideRatio Happy Holidays!

[consideRatio]

Happy holidays @benz0li!! ❤️

Sorry for not helping out here now. I'm currently less available for open-source contributions than I've been for many years.

[ryanlovett]

Thanks for testing @benz0li ! I also think it'd be good to split the PR per @yuvipanda's comments. (the unix socket support and the reduction in subprocess invocation)

I agree that it would be great to have this functionality.

[ryanlovett]

This functionality would be great to have! I added some specific suggestions, and am also in favor of @yuvipanda's suggestion to split the PR.

[ryanlovett]

Similar to the above, could this please beJUPYTER_RSESSION_PROXY_USE_SOCKET instead?

Also, since you check for unix_socket != "" above, I think this can be reduced to if os.getenv("JUPYTER_RSESSION_PROXY_USE_SOCKET") ?

[jhgoebbert]

I realized that there is already RSERVER_TIMEOUT and RSESSION_TIMEOUT. So I did not want to introduce a new naming schema and named the variables also RSERVER_*.
Wouldn't it be better to change all variable names at once in a separate PR?

[jhgoebbert]

This PR gets closed as I have splitted the PR like @yuvipanda asked for in #151 (comment)

• unix-socket-support: Support communicating with rstudio via unix socket instead of tcp socket #159

I will create a PR for the other features as soon as the unix-socket-support is merged.

[jhgoebbert]

The second part of this PR can now be found here

• minimize overhead: minimize overhead when checking the supported args by RStudio #160