Add an integration test for VNC + websockify #93
Conversation
|
I will automatically update this comment whenever this PR is modified
|
.github/workflows/test.yaml
Outdated
| sleep 10 | ||
| curl 'http://localhost:8888/desktop/?token=secret' | grep 'Jupyter Remote Desktop Proxy' | ||
| # Test if the built JS file is present in the image | ||
| curl 'http://localhost:8888/desktop/dist/viewer.js?token=secret' > /dev/null |
There was a problem hiding this comment.
These curl tests have been converted into a pytest as well, and in fact actually caught the fact that the second viewer.js test doesn't actually work (wrong URL in the test, URL has been corrected because pytest caught it.)
|
This works perfectly fine locally, but unfortunately something is causing it to hang when the VNC client is trying to connect to the server on GitHub actions. will have to debug next time i get a chance. |
This tests the following components: 1. The VNC server 2. websockify 3. Jupyter Server Proxy 4. The desktop environment itself It does so by: 1. Building the container image 2. Starting a container with that image, with jupyter server running inside. 3. Connecting to the container via websockets, authenticating and exposing the websocket connection as a regular TCP socket on localhost via [websocat](https://github.com/vi/websocat) 4. Taking a screenshot of the remote desktop by connecting to it through `vncdotool`. This requires a tcp connection, hence the double proxying with websocat 5. Verify that the image produced by the screenshot is the same as a reference image we have. This only misses the noVNC + JS from testing, but otherwise represents a massive improvement to the status quo!
Prevents clashes between multiple runs Also remove some old commented out code
Doesn't actually need to be interactive, we primarily care about sharing stdout
Maybe this is what github actions needs
It did nothing This reverts commit a33a447.
for more information, see https://pre-commit.ci
|
Not needed, now that we have #119 |
This tests the following components:
It does so by:
inside.
exposing the websocket connection as a regular TCP socket on
localhost via websocat
through
vncdotool. This requires a tcp connection, hence thedouble proxying with websocat
reference image we have.
This only misses the noVNC + JS from testing, but otherwise represents
a massive improvement to the status quo!