-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop vendoring noVNC #77
Merged
Commits on Feb 3, 2024
-
We have been vendoring noVNC to get vnc_lite.html, maintaining a patch file so we could upgrade the version of noVNC used if needed. noVNC publishes a JS library [on npm](https://www.npmjs.com/package/@novnc/novnc) that we can easily use instead, and stop vendoring the whole package! This brings us the following massive advantages: 1. No more vendoring an entire package in! 2. Upgrades of noVNC client become practically trivial 3. We can change the frontend as we wish much more easily, compared to having to maintain a patch file as we do now. PRs like #7 become easier. This PR: - Adds a `package.json` to include the noVNC js package - Adds a `webpack.config.js` to provide JS bundling, so we can just ship a single `viewer.js` file that has everything. - Adds appropriate bits (stolen and adapted from jupyterhub's config) to package the built JS in the final wheel as necessary. - Upgrade from noVNC 1.2 to 1.4, but otherwise keep everything the same. I just copied our patched `vnc_lite.html` into `index.html`, and just split out the JS / CSS. - prettier with pre-commit has done its thing on the JS, CSS and HTML. This is fine, as I am hoping we can make more changes to the UI after this. - Modify the `Dockerfile` to setup the conda env first, and then separately install the python package with pip. This makes local development *much* faster. - Add a `.gitignore` (which this repo was missing), with node_modules included as well as the dist/ directory with the built JS.
Configuration menu - View commit details
-
Copy full SHA for a59abc4 - Browse repository at this point
Copy the full SHA a59abc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 823b155 - Browse repository at this point
Copy the full SHA 823b155View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68e25d0 - Browse repository at this point
Copy the full SHA 68e25d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a6e81e - Browse repository at this point
Copy the full SHA 3a6e81eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 296f781 - Browse repository at this point
Copy the full SHA 296f781View commit details -
Configuration menu - View commit details
-
Copy full SHA for 704151c - Browse repository at this point
Copy the full SHA 704151cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ac5182 - Browse repository at this point
Copy the full SHA 7ac5182View commit details
Commits on Feb 4, 2024
-
This allows for much faster iteration, by simply mounting $(pwd) into /opt/install
Configuration menu - View commit details
-
Copy full SHA for 0ba0689 - Browse repository at this point
Copy the full SHA 0ba0689View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfb1a14 - Browse repository at this point
Copy the full SHA cfb1a14View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.