Add logic to determine if vncserver is TigerVNC #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
|
|
|
|
Wieee nice @cmd-ntrf!!! ❤️ 🎉 thank you soo much for super clear PR and relevant comments to help with long term maintenance!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension currently looks first is the executable
vncserveris available inPATH. If it is, this what the extension will use and otherwise the extension the tigervnc bundled with the package.The arguments (i.e.:
vnc_args) provided tovncserverexecutable are also determined based on wether the executable comes from the system or the package bundle. However, it is possible that thevncserverprovided by the system is also TigerVNC and that it could benefits from the same arguments as when using the bundledvncserver.This PR splits that logic in two. First, we determine if
vncservercan be provided by the system, then we determine ifvncserveris TigerVNC or something else. Determining ifvncserveris TigerVNC is a simple matter of looking for a string inside the perl script that isvncserver.