Remove apt.txt and refactor Dockerfile

[consideRatio]

The apt.txt file didn't serve a purpose with a Dockerfile next to it for binder, so I removed it to avoid causing confusion.

The Dockerfile got itself an update, but needs even more updates still, for example so it can avoid introducing a lockscreen etc. I can iterate on that but I'd love to do that in a future PR instead of letting this linger.

• To conclude, this doesn't resolve Dockerfile is broken #15, but is step 1 to enable me to working on resolving that! :)

[github-actions]

👈 Launch a binder notebook on this branch for commit 99543d9

Erik note: this works!

[manics]

I think it's fine to remove apt.txt.

Could we keep environment.yml though? It's helpful for anyone who wants to test this outside Docker, and avoids mixing conda and pip packages. Maybe best to think of the Dockerfile as an example as well as an output artifact.

Unfortunately the version of websockify on PyPI doesn't include the compiled wrapper library which is used by this extension, so either you'd have to manually compile it after pip installing websockify, or use the conda package.

[github-actions]

👈 Launch a binder notebook on this branch for commit e5195e8

[consideRatio]

@manics hmmm okay we can add the environment.yml back, but without any instructions, I couldn't say it was part of what was required or not for the actual local dev etc or if it was something needed by the dockerfile only.

In practice, the environment.yml only installs websockify besides the local python package, but besides having installed that, one need to install other things as well as i understand it, such as dbus-x11 and xfce4-session it seems. I'm not sure about this, but to me, I ended up very confused no matter what.

[github-actions]

👈 Launch a binder notebook on this branch for commit a7bb007

[consideRatio]

I added back environment.yml as dev-environment.yml to clarify it was not associated with the Dockerfile or the binderhub build, but as something for development. I also made it not explicitly install jupyter-server-proxy but letting it be installed via installing the local package instead.

Will the local package be installed in editable mode like this btw, as you probably want for local dev?

[manics]

I still think we should keep it as environment.yml since it's not just for dev, it's a bit in between. If you want we could put this PR on hold until I've dealt with #12 ?

[consideRatio]

If you want we could put this PR on hold until I've dealt with #12 ?

Sure!

[github-actions]

👈 Launch a binder notebook on this branch for commit 9e1c0d8

[consideRatio]

@manics I just re-arrive to this repo and ended up wishing to update things that could come in conflict with this PR, can we go for a merge here without doing #12 first?

[github-actions]

👈 Launch a binder notebook on this branch for commit a9fc17b

[yuvipanda]

I think the Dockerfile here should eventually lead towards something we can use to test changes to this repo. New users should probably steal from https://github.com/binder-templates/binder-desktop-app-template instead, although this repo itself needs more docs.

[yuvipanda]

I'm just going to merge this for now, as removing the apt.txt is definitely an improvement, and we could do further improvements after this. Hope that's ok, @manics