Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle disconnects & reconnects properly #80

Open
yuvipanda opened this issue Feb 4, 2024 · 1 comment
Open

Handle disconnects & reconnects properly #80

yuvipanda opened this issue Feb 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@yuvipanda
Copy link
Contributor

If the websocket disconnects now, the end user has to do a refresh of the page.

Once #77, #78, #79 get merged, we can detect these disconnects and try to reconnect.
yuvipanda added a commit that referenced this issue Feb 4, 2024
@yuvipanda
Automatically reconnect if we lose connection
27f67ce 
This needs much better retry logic, with back-offs and status
messages. But fundamentally, it does already work \o/

Fixes #80
@yuvipanda yuvipanda mentioned this issue Feb 4, 2024
Closed
@consideRatio consideRatio added the bug Something isn't working label Feb 15, 2024
@consideRatio
Copy link
Member

consideRatio commented Mar 29, 2024 •
edited
Loading

I think the initial connection attempt maybe benefit from this also. I've seen the initial connection fail regularly when starting up locally, forcing a page reload - if it fails or not on the first attempt may be related to ping, and the fact that jupyter-server-proxy will finalize the handshake between client/proxy before proxy/server is even initialized (jupyterhub/jupyter-server-proxy#459) which makes initial traffic possibly disrupted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically reconnect if we lose connection jupyterhub/jupyter-remote-desktop-proxy
2 participants
@yuvipanda @consideRatio