Skip to content

Commit

Permalink
Add eslint & fix the one issue it found
Browse files Browse the repository at this point in the history
  • Loading branch information
yuvipanda committed Feb 3, 2024
1 parent c793783 commit 0faedee
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
9 changes: 9 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,15 @@ repos:
hooks:
- id: flake8

# Lint: JS code
- repo: https://github.com/pre-commit/mirrors-eslint
rev: "v8.56.0" # Use the sha / tag you want to point at
hooks:
- id: eslint
files: \.jsx?$
types: [file]
exclude: jupyter_remote_desktop_proxy/static/dist

# Content here is mostly copied from other locations, so lets not make
# formatting changes in it.
exclude: share
Expand Down
2 changes: 1 addition & 1 deletion js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ let desktopName;

// When this function is called we have
// successfully connected to a server
function connectedToServer(e) {
function connectedToServer() {
status("Connected to " + desktopName);
}

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
},
"devDependencies": {
"babel-loader": "^9.1.3",
"eslint": "^8.56.0",
"webpack": "^5.90.1",
"webpack-cli": "^5.1.4"
}
Expand Down

0 comments on commit 0faedee

Please sign in to comment.