avoid name collisions when using named servers #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Thanks for cleaning up after me. :- D |
|
Tests are failing because conftests imports some fixtures from jupyterhub that are new in 1.0. Need to work around that... |
|
@GeorgianaElena already started work on updating the tests for JupyterHub 1.0 #379 |
|
I didn't know what to do about the |
minrk
changed the title
prioritize already running names over new template config
separator must not be a safe character or the escape character to avoid collisions '.' is not in the safe char list, but is a valid docker identifier - servername is template variable is escaped, matching username - add raw_servername for the raw value - fix safe_username to be the safe version
. is not safe in swarmspawner, since it's a DNS component let's be consistent, at least
|
Thanks, Min ❤️ ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we haven't made a release yet with #315 (merged last month), but the default template added there allows collisions between certain usernames and named servers because
-is considered a safe character and not escaped.This changes the default template to use
__, the doubled escape character (same as on KubeSpawner, which uses-as the escape character), which cannot occur in an escaped username or servername.This also ensures the escaped form of servername is used in the template, matching handling of usernames.
Additionally, this persists object_name in state, to avoid changes in the template (as is done here) from causing a disconnect between objects across configuration changes.
That is, changes in the template will only affect newly created objects, not ones that already exist.
/cc @danielballan