[MRG] Add basic news header to the HTML templates #881
Conversation
There was a problem hiding this comment.
This looks good to me, and I think is quite helpful!
Two quick nits on the "id" name, but I can go either way on those.
One thought: should we by default make the banner more noticeable? I'm assuming that most folks will use the banner sparingly, and will want people to notice whatever is inside. So maybe a font-size: 2em and aligning in the center instead of the left side by default?
Either way, I don't think those points should block this one from being merged, I'll plan to merge it in tomorrow AM if nobody objects
|
Renamed the ID used. I was wondering about bolder/bigger font or colours and though that because the banner can't be dismissed keeping it somewhat "not in your face" would be good. Speculating that the fact that it normally isn't there is enough to make people notice it. |
Co-Authored-By: Chris Holdgraf <choldgraf@gmail.com>
|
As two people gave a positive review I am merging it now instead of waiting till California wakes up. This way we can start using it for the user survey. |
This PR adds the ability to have a basic "news" banner at the top of all pages. You can set the HTML to be displayed inside the banner via a config option.
Closes #877
When the message is not an empty string a banner with grey background (like the form) will appear at the top of each page (landing, loading, about, error, etc).