Upgrade xterm to 3.11.0 and remove vendored addon #787
Conversation
|
I'm going to need an assist from @captainsafia or @yuvipanda (or someone else who understands what we are doing in terms of JS and TS and webpack). I've updated the code. I think this is how you should use the xterm extensions mechanism. Visiting http://localhost:8585 gives me this error:
To setup things:
|
| @@ -144,7 +143,7 @@ function build(providerSpec, log, path, pathType) { | |||
| image.onStateChange('*', function(oldState, newState, data) { | |||
| if (data.message !== undefined) { | |||
| log.write(data.message); | |||
| log.fit(); | |||
| fit(log); //log.fit(); | |||
There was a problem hiding this comment.
Turning this around so that you don't need applyAddon is what jupyter lab does as well and seems to work.
|
With the changed way of using |
| @@ -444,6 +444,9 @@ def initialize(self, *args, **kwargs): | |||
| kubernetes.config.load_kube_config() | |||
| self.tornado_settings["kubernetes_client"] = self.kube_client = kubernetes.client.CoreV1Api() | |||
|
|
|||
| else: | |||
There was a problem hiding this comment.
Is this change related to the upgrade?
There was a problem hiding this comment.
I needed this (as a hack) to be able to run in "frontend dev only mode". I didn't spend a lot of time trying to work out why this change or how else one could fix it. Once this PR works we should think about the proper way of fixing this (or punting to a new PR).
|
Just read some feedback from a workshop that used Binder and one comment was "I wouldn't have ever thought of unfolding that logging pane" which makes me wonder: should we have it open by default? Less tidy but easier to discover and maybe gives more of an impression of "wow, stuff is happening!". If we started toggled open I think that would solve the problem here of the plugin being confused about starting from size zero. So we could still have the toggle to hide the logs for those who aren't calmed by seeing them. Reflecting on my personal usage pattern I almost always unfold the logs to see what is up and I think in the few cases where I don't care about keeping track of progress I'd probably also not care about a busy log scrolling by. |
|
I too prefer the logs to be open by default... |
|
In that case, maybe it is worth exploring having the logs open by default as a way to workaround the issue @betatim mentioned and to provide this to users. Might kill two birds with one stone. |
|
See #1365 |
The goal of this PR is to get us to xterm.js 3.11.0.
I had hoped that this was just a matter of editing
package.jsonbut alas no :(My guess is that something needs changing in our webpack config because xterm.js is no typescript based??
The state of this PR results in the following error in the console after running
npm run webpack && python3 -m binderhub -f testing/minikube/binderhub_config.py(withnvm versionshowing v11.7.0)I don't think this has anything to do with the addon because if you remove all reference to the addon you get:
So I think something about how we import the xterm stuff needs to change. Could someone point me in a/the right direction for reading material?