Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authentication tests #770

Merged
merged 4 commits into from
Jan 16, 2019
+13 −34
Merged

Update authentication tests #770

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
968cf95
escape oauth_redirect_uri when adding into handlers
bitnik Jan 14, 2019
1368f3f
make oauth_redirect_uri required
bitnik Jan 14, 2019
6b91c47
use oauth_redirect_uri in auth tests
bitnik Jan 14, 2019
7f82dcb
set JUPYTERHUB_HOST env var (it is needed when jhub and binder runs o…
bitnik Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make oauth_redirect_uri required
  • Loading branch information
@bitnik
bitnik committed Jan 15, 2019
commit 1368f3f0aa0e3784f419cc8f1d8d845f5399e8b7
2 changes: 0 additions & 2 deletions helm-chart/binderhub/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,9 @@ spec:
value: {{ .Values.jupyterhub.hub.baseUrl | quote }}
- name: JUPYTERHUB_CLIENT_ID
value: {{ .Values.jupyterhub.hub.services.binder.oauth_client_id | quote}}
{{- if .Values.jupyterhub.hub.services.binder.oauth_redirect_uri }}
- name: JUPYTERHUB_OAUTH_CALLBACK_URL
value: {{ .Values.jupyterhub.hub.services.binder.oauth_redirect_uri | quote}}
{{- end }}
{{- end }}
ports:
- containerPort: 8585
name: binder