Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: req py36+ and jh 1.5.1+, fix tests, add RELEASE.md, add pre-commit hooks, add dependabot #273
maint: req py36+ and jh 1.5.1+, fix tests, add RELEASE.md, add pre-commit hooks, add dependabot #273
Changes from 16 commits
0cdc409
d10047a
1d8163b
a7ea239
c8430a8
33eddfc
1790683
45d4d6a
3269efd
8a607cd
224ec3e
d442d74
2b65886
479dcce
63c6bdc
9d9fac2
8cfc952
a2f2d61
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When @mbmilligan was working on #252, I think the user community mentioned that 3.6 was the default python on the Red Hat distributions they were using. I believe the feedback was they tended to use the system python rather than containers or virtual environments. It may have been discussed at the Sep. 2022 meeting.
I don't know if anyone affected by bumping minimum python would be okay with not being able to use the latest batchspawner. However this change is reasonable to me since it is feasible to run jupyterhub in a container or virtual environment on top of older distributions/kernels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I found these notes:
For reference, Python 3.7 reaches end-of-life state 28th June.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given most HPC systems run some variant of CentOS, and RH technically provides security support for packages in it until EOL, https://endoflife.date/centos is also relevant. And that ends in 2024. And then I think there's going to be a fairly delayed migration, as IBM bought RedHat and totally fucked everything up over the last few years :D
So I think it would be useful to not drop 3.6 support as part of this PR, because batchspawner / HPC systems have unfortunately different needs than the rest of the ecosystem. I'm very much pro dropping 3.6 support, just in a separate PR to unblock merging this one.
This file was deleted.