Fix Slurm test used regular expression #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
consideRatio
force-pushed
the
fix-slurm-test
branch
from
c092d7e
to
0805672
Compare
consideRatio
force-pushed
the
fix-slurm-test
branch
from
0805672
to
f3b7746
Compare
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thank you for the clear motivation for the change @t20100! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regular expressions used to validate the submitted batch script.
Indeed according to re.X documentation:
So all regular expressions were matching to the line start.