Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapspawner/JH0.9.4 compatibilty: get_current_user and current_port #132

Closed
wants to merge 2 commits into from

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Feb 2, 2019

This fixes two problems:

First is a compatibility for JupyterHub later than 0.9.4 (but not inclusive). get_current_user became async, and thus we need to handle both old and new hubs. This adds some logic to use the non-async version to avoid making this whole method async - because jupyterhub.util.maybe_future is also relatively new so would need backwards compatibility to use itself. Closes: #131

Second, wrapspawner has to proxy the self.current_port setting to self.child_spawner.current_port. It would be better to solve this in wrapspawner, since many different things could be set. But this might solve the problem faster. Closes: #129, #127,

These are together because they touch lines almost identical to each other. They can easily be split.

@rkdarst
Copy link
Contributor Author

rkdarst commented Jun 16, 2019

Closed in favor of #143 and other PRs which are mentioned there.

@rkdarst rkdarst closed this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant