Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set collaborative attribute to False in Jupyterlite #525

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

martinRenou
Copy link
Member

This has the side effect of fixing the saving of files in JupyterLite for now

This has the side effect of fixing the saving of files in JupyterLite
for now
@martinRenou martinRenou added the bug PR that fixes a bug label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Preview PR at appsharing.space

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Integration tests repot: appsharing.space

Co-authored-by: Duc Trung Le <leductrungxf@gmail.com>
@martinRenou martinRenou marked this pull request as draft October 22, 2024 16:17
packages/schema/src/model.ts Outdated Show resolved Hide resolved
python/jupytercad_core/src/jcadplugin/modelfactory.ts Outdated Show resolved Hide resolved
python/jupytercad_core/src/stepplugin/modelfactory.ts Outdated Show resolved Hide resolved
python/jupytercad_core/src/stlplugin/modelfactory.ts Outdated Show resolved Hide resolved
@martinRenou martinRenou marked this pull request as ready for review October 22, 2024 17:06
@martinRenou
Copy link
Member Author

Working! Let's go ahead with this

@martinRenou martinRenou merged commit 9fde6ed into jupytercad:main Oct 22, 2024
8 of 9 checks passed
@martinRenou martinRenou deleted the fix_saving_in_lite branch October 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants