Added support for different message formats (JSON, LightPayload, MessagePack) #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional implented Xterm.js addon supporting all server-side message formats.
Additionally merged .gitignore file for the static files with the main .gitignore file.
It is now possible to select the message format right from the beginning, rather than switching from JSON (usually the server's default message format) to the desired message format. Fixed issue, the RTYPES properties were not correctly swapped, as such unpacking packs fpr LightPayload and MessagePack didn't work and no message were received (due to the type being empty).
devmonkey22
added a commit
to devmonkey22/terminado
that referenced
this pull request
Jun 10, 2019
…ultiple tornado tests;
devmonkey22
added a commit
to devmonkey22/terminado
that referenced
this pull request
Jun 10, 2019
…y deps (since jupyter#65 isnt merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional implemented Xterm.js addon supporting all server-side message formats.
Additional to the original message format, there is now support for:
There is a new command called
switch_formatwhich allows switching the message format on the fly. The client-side will issue this command right after connecting so that the client-side can choose the initial message format without depending on the server-side.The default message format on the server-side is JSON, as was. The JSON message format is fully backwards-compatible to the version before this PR.