Fix packages of exceptions catched by gateway manager #5055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuichiro-makigaki
changed the title
shuichiro-makigaki
force-pushed
the
fix-gateway-handled-exceptions
branch
from
958e702 to
ee28120
Compare
shuichiro-makigaki
changed the title
kevin-bates
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
@shuichiro-makigaki - thank you for these changes! I wonder if something was introduced that prevents restarts or new starts following culling because this should have been seen before. I've confirmed these changes - thanks again!
|
@shuichiro-makigaki - would you mind submitting essentially this same PR against jupyter_server? |
`gateway_request` in `gateway.manager` raises `tornado.web.HTTPError` exceptions, but the callers, such as `GatewayKernelManager.get_kernel`, catch `tornado.httpclient.HTTPError`, instead of `tornado.web.HTTPError`. Therefore, the callers can not handle exceptions during gateway interactions. This causes that, for example, when Jupyter Enterprise Gateway culled a kernel by idle timeout, the gateway manager can not handle the kernel's absent appropriately. As a result, notebook users see ambiguous "Kernel Error" and can not restart the kernel or start a new kernel.
shuichiro-makigaki
force-pushed
the
fix-gateway-handled-exceptions
branch
from
ee28120 to
aa73eb4
Compare
|
I added some fixes to tests also.
|
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gateway_requestingateway.managerraisestornado.web.HTTPErrorexceptions, but the callers, such asGatewayKernelManager.get_kernel, catchtornado.httpclient.HTTPError, instead oftornado.web.HTTPError. Therefore, the callers can not handle exceptions during gateway interactions.This causes that, for example, when Jupyter Enterprise Gateway culled a kernel by idle timeout, the gateway manager can not handle the kernel's absent appropriately. As a result, notebook users see ambiguous "Kernel Error" and can not restart the kernel or start a new kernel.