Make FilesHandler.get() a decorated coroutine. Closes #4869
#4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added decorator `@gen.coroutine` to `FileHandler.get()`
TomTJarosz
changed the title
ContentsManager is implemented #4869FilesHandler.get() a decorated coroutine. Closes #4869
|
@Carreau @minrk @gnestor Sorry to bother, but I would like to "poke" the Jupyter team regarding this issue. This is a (significant) blocking issue for my team, and (to the best of my knowledge) has a very simple fix. If there is any part of the "PR procedure" I am missing or any possible way I can accelerate progress on this issue, please let me know. Thanks! |
gnestor
approved these changes
Sep 24, 2019
|
@Carreau Care to review and merge? |
|
Thanks! Sorry for the delay. |
|
Thanks a lot! |
This was referenced Sep 24, 2019
|
Hi @lresende - would it be possible to release a new hotfix release 6.0.2 with this and any other changes that have accumulated on |
|
@HarryWeppner Give a couple of days to get an overall assessment of where we are in general for a release. |
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch resolves #4869