Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify contributing instructions to use pytest for testing #3789

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

munkm
Copy link
Contributor

@munkm munkm commented Jul 20, 2018

At the scipy sprints it was suggested that I use pytest rather than nose to run the jupyter notebook tests. I had been following the contributing documentation that directs using nose. This PR

  • modifies the contributing instructions to use pytest when running the notebook tests
  • adds pytest and pytest-cov to the the test key in extras_require so that pytest and the coverage package are included in the test dependencies.

@minrk minrk merged commit 5711075 into jupyter:master Sep 26, 2018
@minrk minrk added this to the 6.0 milestone Sep 26, 2018
@minrk
Copy link
Member

minrk commented Sep 26, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants