[WIP] remove components submodule #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bower install` in package repo fetches components
require `setup.py css` to run
from JupyterHub - fetches node tools locally with npm - runs bower - setup.py css uses local less as well, so no need to `npm install -g` anything.
Merged
|
Continuing in #8. |
svurens
pushed a commit
to svurens/notebook
that referenced
this pull request
Aug 6, 2015
moved commandpalette to new class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the components submodule and compiled css files, instead relying on bower to fetch the dependencies and less to build css.
Running the notebook from master will from now on require npm.
It works already, the only pieces I want to get in before merging are distutils hooks for triggering the npm, bower, and less calls, which I will mostly copy from JupyterHub where this same pattern is already working well.