V7: Untrusted notebook on releoad.

[Carreau]

V7 seem to emit invalid notebooks.

I see the following in the terminal

MissingIDFieldWarning: Code cell is missing an id field, this will become a hard error in future nbformat versions. You may want to use `normalize()` on your notebooks before validations (available since nbformat 5.1.4). Previous versions of nbformat are fixing this issue transparently, and will stop doing so in the future.
  validate(nb)

This seem to prevent notebooks to be trusted.

[jtpio]

This was recently investigated in jupyterlab/jupyterlab#14025.

With some incremental improvements upstream in jupyterlab/jupyterlab#14039.

cc @krassowski who probably knows more about it

[krassowski]

Yes it's also on my schedule for this weekend ;) this will need a PR to shared models/ydoc

[jtpio]

Nice, thanks @krassowski!

[krassowski]

MissingIDFieldWarning: Code cell is missing an id field, this will become a hard error in future nbformat versions. You may want to use normalize() on your notebooks before validations (available since nbformat 5.1.4). Previous versions of nbformat are fixing this issue transparently, and will stop doing so in the future.

If nbformat is fixing the issue transparently, then it should not be the reason for untrusted notebook, right? I opened jupyter/nbformat#359 to discuss.

[krassowski]

@Carreau would you be able to provide a bit more detailed reproduction steps? I could not replicate this behaviour. Both Notebook and Lab emit notebooks with cell IDs present for me.

[Carreau]

Hu, I can't in a fresh env... This is weird. Maybe there is a sequence of interaction that create a cell that has no ID... I'll close this for now and reopen if I encounter it again.

[jtpio]

This was recently investigated in jupyterlab/jupyterlab#14025.

With some incremental improvements upstream in jupyterlab/jupyterlab#14039.

cc @krassowski who probably knows more about it

[krassowski]

Yes it's also on my schedule for this weekend ;) this will need a PR to shared models/ydoc

[jtpio]

Nice, thanks @krassowski!

[krassowski]

MissingIDFieldWarning: Code cell is missing an id field, this will become a hard error in future nbformat versions. You may want to use normalize() on your notebooks before validations (available since nbformat 5.1.4). Previous versions of nbformat are fixing this issue transparently, and will stop doing so in the future.

If nbformat is fixing the issue transparently, then it should not be the reason for untrusted notebook, right? I opened jupyter/nbformat#359 to discuss.

[krassowski]

@Carreau would you be able to provide a bit more detailed reproduction steps? I could not replicate this behaviour. Both Notebook and Lab emit notebooks with cell IDs present for me.

[Carreau]

Hu, I can't in a fresh env... This is weird. Maybe there is a sequence of interaction that create a cell that has no ID... I'll close this for now and reopen if I encounter it again.