-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter server #1586
Jupyter server #1586
Conversation
pyproject.toml
Outdated
@@ -1,3 +1,7 @@ | |||
[build-system] | |||
requires = ["jupyter_packaging~=0.5.0", "setuptools>=40.8.0", "wheel"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we need to stick to 0.5.x
for jupyter packaging here.
Or if it could be bumped to a more recent version, for example: jupyter_packaging~=0.12.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also of note, we will probably soon be able to drop jupyter-packaging
and switch to hatch
(in a later PR):
It's not ready to be merged yet, this version still uses the Edit : |
…ion (respectively notebook.notebookapp.NotebookApp or jupyter_server.serverapp.ServerApp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Perhaps @jtpio can take another look as well before merging.
Nice thanks @brichet! |
Also, do we already test that the extensions are loaded and enabled on CI? Otherwise maybe we should add a check on CI that runs |
No, there is no test on the installation and activation of extensions yet. We may add it. |
This PR is a starting point for using labextensions :