Skip to content

Fix deprecation warning when importing from jsonschema #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2023
Merged

Fix deprecation warning when importing from jsonschema #368

merged 3 commits into from
Jul 7, 2023

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Jul 6, 2023 •
edited
Loading

jsonschema v4.18.0 deprecated
importing of jsonschema.ErrorTree
instead import it via jsonschema.exceptions.ErrorTree

https://github.com/python-jsonschema/jsonschema/releases/tag/v4.18.0

This to avoid warning raised:

 /usr/local/lib/python3.8/site-packages/nbformat/json_compat.py:14:Importing ErrorTree directly from the jsonschema package is deprecated and will become an ImportError. Import it from jsonschema.exceptions instead.
/usr/local/lib/python3.8/site-packages/nbformat/json_compat.py:14:Importing ErrorTree directly from the jsonschema package is deprecated and will become an ImportError. Import it from jsonschema.exceptions instead.

@eladkal eladkal mentioned this pull request Jul 6, 2023
Merged
@jstorrs jstorrs mentioned this pull request Jul 6, 2023
Merged
blink1073
blink1073 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) July 7, 2023 18:11
@blink1073 blink1073 disabled auto-merge July 7, 2023 18:14
@blink1073 blink1073 enabled auto-merge (squash) July 7, 2023 18:14
@blink1073
Copy link
Contributor

I'll cut a release with this early next week.

@blink1073 blink1073 disabled auto-merge July 7, 2023 18:26
@blink1073 blink1073 merged commit c348f9d into jupyter:main Jul 7, 2023
@eladkal eladkal deleted the deprecation branch July 7, 2023 19:10
@h-vetinari h-vetinari mentioned this pull request Jul 8, 2023
Closed
@tjni tjni mentioned this pull request Jul 23, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@blink1073 blink1073 blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eladkal @blink1073