Apply post-mortem review comments #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fcollonval
commented
Oct 16, 2023
fcollonval
commented
- Remove debug console.log
- Restore dep for update-dependency helper
- Set the CLI arg for showBase only for the nbmerge web
- Test the label change for showBase option
Review comment from jupyter#708
Review comment from jupyter#706
|
Thanks @vidartf - I gathered all your post-mortem comments within this PR. |
fcollonval
commented
Oct 16, 2023
|
Merging to include it in the new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.