Improve diff view #696
Merged
Improve diff view #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
|
Kicking the CI |
Improve alignment (homogeneous grid usage) Remove unneeded gutter in diff view
fcollonval
force-pushed
the
fix/695-Gap-element-wrongly-positioned-in-diff-widget
branch
from
d18ca72
to
ca01a92
Compare
|
bot please update playwright snapshots |
|
Playwright ubuntu-22.04 snapshots updated. |
|
Playwright windows-latest snapshots updated. |
|
Kicking the CI |
fcollonval
commented
Sep 29, 2023
krassowski
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
A follow-up task would be adding a visual test which includes gitter with pickers for empty chunks fixed in an earlier PR as this one will no longer test that.
fcollonval
deleted the
fix/695-Gap-element-wrongly-positioned-in-diff-widget
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore gap element in diff view
Improve alignment (homogeneous grid usage)
Remove unneeded gutter in diff view
Fixes #695