A bunch of pre-commit and CI upgrade. #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Carreau
commented
Feb 26, 2025
Carreau
commented
- precommit-ci is not sending any updates because of branch protection rules.
- Update and fix corresponding errors.
- run mypy as part of CI.
Carreau
commented
Feb 26, 2025
| files: jupyter_core | ||
| stages: [manual] | ||
| args: ["--install-types", "--non-interactive"] | ||
| additional_dependencies: ["traitlets>=5.13", "platformdirs>=3.11"] |
Member
Author
There was a problem hiding this comment.
"--install-types", "--non-interactive" will actually silence some errors are they are ment to be run locally, I think this is a mypy bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.