Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning from traitlets #158

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Jul 12, 2019

Hello,

This PR fixes warnings like this:

  • DeprecationWarning: DummyConsoleApp._runtime_dir_changed is deprecated in traitlets 4.1: use @observe and @unobserve instead.

This commit fixes warnings like this:

 - DeprecationWarning: DummyConsoleApp._runtime_dir_changed is deprecated in traitlets 4.1: use @observe and @unobserve instead.
@Jamim
Copy link
Contributor Author

Jamim commented Jul 23, 2019

Hi @takluyver,
Could you please take a look at this PR?
Thank you!

@Jamim
Copy link
Contributor Author

Jamim commented Jul 31, 2019

Hello @minrk,
Can you please review this PR?
Thanks!

@minrk minrk merged commit 9d0a86b into jupyter:master Aug 5, 2019
@minrk
Copy link
Member

minrk commented Aug 5, 2019

Thanks!

@Jamim Jamim deleted the fix/warnings branch August 5, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants