Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown and cleanup behavior #772

Merged
merged 22 commits into from
Apr 25, 2022
Merged

Fix shutdown and cleanup behavior #772

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5dd22cd
fix shutdown behavior
blink1073 Apr 17, 2022
e409fd1
lint
blink1073 Apr 17, 2022
164f45d
fix test and fix loop handling
blink1073 Apr 17, 2022
9dbe109
more cleanup
blink1073 Apr 17, 2022
bf678f2
fix handling of context
blink1073 Apr 17, 2022
d22789c
fix handling of cov-fail-under
blink1073 Apr 17, 2022
f23f9fb
lint
blink1073 Apr 17, 2022
dc47363
try again
blink1073 Apr 18, 2022
0b773dd
try again
blink1073 Apr 18, 2022
67d6b58
try to fix ipykernel
blink1073 Apr 18, 2022
af02fad
try to fix ipykernel again
blink1073 Apr 18, 2022
8039c95
try to fix ipykernel again
blink1073 Apr 18, 2022
7754880
restore other loop closes
blink1073 Apr 18, 2022
834b83f
cleanup
blink1073 Apr 18, 2022
ee2be0d
cleanup
blink1073 Apr 18, 2022
dc8d412
wip
blink1073 Apr 21, 2022
0a2c228
work around event loop limitation
blink1073 Apr 24, 2022
270cec6
more cleanup
blink1073 Apr 24, 2022
db270dc
fix import
blink1073 Apr 24, 2022
0168bef
clean up context handling
blink1073 Apr 24, 2022
a50d602
more context cleanup
blink1073 Apr 24, 2022
523ba88
more context cleanup
blink1073 Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix import
  • Loading branch information
@blink1073
blink1073 committed Apr 24, 2022
commit db270dc1a7e36325196d034cdc84c7466f75c8fa
4 changes: 2 additions & 2 deletions jupyter_client/multikernelmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ async def _async_shutdown_kernel(
await task
km = self.get_kernel(kernel_id)
await t.cast(asyncio.Future, km.ready)
except asyncio.exceptions.CancelledError:
except asyncio.CancelledError:
pass
except Exception:
self.remove_kernel(kernel_id)
Expand Down Expand Up @@ -302,7 +302,7 @@ async def _async_shutdown_all(self, now: bool = False) -> None:
for km in kms:
try:
await km.ready
except asyncio.exceptions.CancelledError:
except asyncio.CancelledError:
self._pending_kernels[km.kernel_id].cancel()
except Exception:
# Will have been logged in _add_kernel_when_ready
Expand Down