Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt KernelManager._kernel_spec_manager_changed to observe #588

Merged
merged 1 commit into from
Nov 20, 2020
Merged

adapt KernelManager._kernel_spec_manager_changed to observe #588

merged 1 commit into from
Nov 20, 2020

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Nov 11, 2020

Closes #386

kevin-bates
kevin-bates approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle. The attention to B/C for subclasses is appreciated.

@rgbkrk rgbkrk merged commit 996b53e into jupyter:master Nov 20, 2020
@rgbkrk rgbkrk deleted the migrate-to-observe-ksmgr-changed branch November 20, 2020 16:42
@jli jli mentioned this pull request Dec 3, 2020
Closed
@takluyver
Copy link
Member

I think this didn't quite avoid an issue - the method is missing the change parameter that @observe_compat expects.

@takluyver
Copy link
Member

#598 is the change I think is needed to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session._key_changed is deprecated in traitlets 4.1
3 participants
@rgbkrk @takluyver @kevin-bates