Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JupyterCon logo in banner #705

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Update JupyterCon logo in banner #705

merged 1 commit into from
Nov 2, 2022

Conversation

SylvainCorlay
Copy link
Member

No description provided.

@SylvainCorlay SylvainCorlay force-pushed the update-jupytercon-logo branch 12 times, most recently from 5db9f3f to 56d6041 Compare November 2, 2022 15:52
choldgraf
choldgraf approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I noticed the image isn't scaling properly on mobile. Maybe it needs a max-width in there somewhere?

Imo it's fine in a follow up if you want though

choldgraf
choldgraf approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@SylvainCorlay SylvainCorlay merged commit 19f78e4 into jupyter:master Nov 2, 2022
@SylvainCorlay SylvainCorlay deleted the update-jupytercon-logo branch November 2, 2022 17:09
@SylvainCorlay
Copy link
Member Author

Thanks. I went ahead and merged. I will be iterating on this as more design assets come along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SylvainCorlay @choldgraf