Skip to content

Accessible orange hyperlink #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2021
Merged

Accessible orange hyperlink #581

merged 3 commits into from
Dec 29, 2021

Conversation

palewire
Copy link
Collaborator

No description provided.

@palewire palewire mentioned this pull request Dec 29, 2021
Merged
choldgraf
choldgraf reviewed Dec 29, 2021
View reviewed changes
@palewire @choldgraf
Update _sass/settings/_colors.scss
c465d5a 
Co-authored-by: Chris Holdgraf <choldgraf@berkeley.edu>
choldgraf
choldgraf approved these changes Dec 29, 2021
View reviewed changes
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the quick turnaround

@choldgraf choldgraf merged commit b868aeb into master Dec 29, 2021
@slel
Copy link
Contributor

slel commented Dec 30, 2021

Dark orange text on white and black text on light orange, well done.
Using the same orange in both cases was likely to hurt accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palewire @slel @choldgraf