-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use pytest-regression in our test suit #265
Conversation
I have a bit mixed feelings about this approach. Pros:
Cons:
I don't think the drawbacks are severe, but I wanted to bring them up for consideration. |
I also thought about it but I didn't find efficient ways to parse doctree nodes as a json tree which would have allowed me to continue testing the document object. That being said, the final result is the html output and changes from sphinx needs to be captured very early by the tests to avoid breaking custom css and themes so I think it brings lots of advantages as well. It is still possible to use other builders if the html output is not sufficient or if issues are identified in pdf or epub. At the moment the PR is not ready for review as the pre-commit hooks are conflicting with the generated files. |
@akhmerov do you have any last though on this one before I merge it ? |
Sorry for not being clear. I think this is a perfectly fine solution that removes a lot of boilerplate. |
Fix #122