-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating with new JEP process #52
Conversation
7d4a027
to
51e83ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall -- a few small comments inline.
| | ||
+--------------+ +-----------+ +-----+-----+ +-------------+ +-----------+ | ||
| | | | | | | | | | | ||
| pre-proposal +---> submitted +--------------> RFC/FCP +-------------> in progress +---> completed | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Perhaos make this RFC (Request for Comments)
for people who might be unfamiliar with the term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me, OK if I leave out the "FCP" in that case, to save space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep -- sounds reasonable.
``` | ||
+-----------+ | ||
| | | ||
+-----------+ | withdrawn | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an arrow that takes you from one (or more) of the steps to withdrawn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I wondered about this too - I wasn't sure how to do this without having a bunch of arrows cluttering up the viz. Maybe we can have a "floating arrow" that doesn't come directly from one box to make it clear that at any point it can move into "withdrawn"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Floating arrow works. Or and endnote in the document that lets people know you can move from any state to withdrawn. Endnote seems like it would be the least obtrusive and most informative.
ae32ef8
to
3d54989
Compare
OK, just added a commit that addresses both of your comments. For the "withdrawn" section, I added a short note in the diagram, as well as note at the beginning of the "phases" section of the document |
Sounds good -- thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing on this!
jupyter-enhancement-proposal-guidelines/jupyter-enhancement-proposal-guidelines.md
Show resolved
Hide resolved
6840487
to
e32a811
Compare
Hey all - comments addressed. Ready to merge from my perspective (note this should be seen as one PR implementing JEP #29 , and more can follow if there are other things to improve), or happy to address more comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
wohoo! thanks all for your comments |
This is one step towards implementing the meta-JEP from #29
It does the following:
Happy to take comments or suggestions!