Skip to content

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

# This way we make sure we don't access wiki pages from several jobs simultaneously

env:
PUSH_TO_REGISTRY: ${{ (github.repository_owner == 'jupyter' || github.repository_owner == 'mathbunnyru') && (github.ref == 'refs/heads/main' || github.event_name == 'schedule') }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think wiki is created automatically, and given these changes we can actually generate wiki changes in forks as well

@@ -0,0 +1,27 @@
# Jupyter Docker Stacks build manifests

<!-- Note: this file is copied to wiki from the main repo, edits on wiki page will be overridden -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this comment to show that edits on the wiki page are not saved

@@ -0,0 +1,27 @@
# Jupyter Docker Stacks build manifests
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this file to a repo makes it easier to make PRs - now we have even less reasons to manipulate wiki repo manually.
And forks will get nice wiki pages by default


Note: we only store the last 4500 manifest files because of GitHub limits.
That's why old manifest files might not be available.
If you want to clone this repo and access the Git history, use the following command: `git clone git@github.com:{REPOSITORY}.wiki.git`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In forks this will be a link to a fork wiki

@mathbunnyru mathbunnyru merged commit e796b11 into jupyter:main Feb 20, 2025
96 checks passed
@mathbunnyru
Copy link
Member Author

@fbnrst I think you'll like this change, makes handling wiki in forks even easier. No there is no need to manually push Home.md to the fork wiki, you can just adjust the one in the repo.
And even commits link and clone url will be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant