-
Notifications
You must be signed in to change notification settings - Fork 3k
Properly generate wiki home page in forks #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# This way we make sure we don't access wiki pages from several jobs simultaneously | ||
|
||
env: | ||
PUSH_TO_REGISTRY: ${{ (github.repository_owner == 'jupyter' || github.repository_owner == 'mathbunnyru') && (github.ref == 'refs/heads/main' || github.event_name == 'schedule') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think wiki is created automatically, and given these changes we can actually generate wiki changes in forks as well
@@ -0,0 +1,27 @@ | |||
# Jupyter Docker Stacks build manifests | |||
|
|||
<!-- Note: this file is copied to wiki from the main repo, edits on wiki page will be overridden --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this comment to show that edits on the wiki page are not saved
@@ -0,0 +1,27 @@ | |||
# Jupyter Docker Stacks build manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this file to a repo makes it easier to make PRs - now we have even less reasons to manipulate wiki repo manually.
And forks will get nice wiki pages by default
|
||
Note: we only store the last 4500 manifest files because of GitHub limits. | ||
That's why old manifest files might not be available. | ||
If you want to clone this repo and access the Git history, use the following command: `git clone git@github.com:{REPOSITORY}.wiki.git` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In forks this will be a link to a fork wiki
@fbnrst I think you'll like this change, makes handling wiki in forks even easier. No there is no need to manually push |
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)