Skip to content

Improve handling of tensorboard #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Improve handling of tensorboard #2126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a06fa3
Improve handling of tensorboard
twalcari Jul 19, 2024
645854c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 19, 2024
014fa60
Improve style
mathbunnyru Jul 19, 2024
a855344
Merge branch 'main' into tensorboard-via-jupyter-server-proxy
mathbunnyru Jul 25, 2024
5abf4fc
Move bash file to cuda-subdir
twalcari Jul 25, 2024
bb83a54
Update tensorflow-notebook info
twalcari Jul 25, 2024
3b154a9
Fix redirect link
mathbunnyru Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/using/selecting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ It contains:
`jupyter/tensorflow-notebook` includes popular Python deep learning libraries.

- Everything in `jupyter/scipy-notebook` and its ancestor images
- [tensorflow](https://www.tensorflow.org/) machine learning library
- [TensorFlow](https://www.tensorflow.org/) machine learning library
- [Jupyter Server Proxy](https://jupyter-server-proxy.readthedocs.io/en/latest/) to support [TensorBoard](https://www.tensorflow.org/tensorboard)

### jupyter/pytorch-notebook

Expand Down
6 changes: 5 additions & 1 deletion images/tensorflow-notebook/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]

# Install tensorflow with pip, on x86_64 tensorflow-cpu
RUN [[ $(uname -m) = x86_64 ]] && TF_POSTFIX="-cpu" || TF_POSTFIX="" && \
pip install --no-cache-dir "tensorflow${TF_POSTFIX}" && \
pip install --no-cache-dir \
"tensorflow${TF_POSTFIX}" \
"jupyter-server-proxy" && \
fix-permissions "${CONDA_DIR}" && \
fix-permissions "/home/${NB_USER}"

COPY --chown="${NB_UID}:${NB_GID}" cuda/20tensorboard-proxy-env.sh /usr/local/bin/before-notebook.d/
10 changes: 10 additions & 0 deletions images/tensorflow-notebook/cuda/20tensorboard-proxy-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/bin/bash
# Copyright (c) Jupyter Development Team.
# Distributed under the terms of the Modified BSD License.

set -e

# Initialize the TENSORBOARD_PROXY_URL with the appropriate path
# to use jupyter-server-proxy.

export TENSORBOARD_PROXY_URL="${JUPYTERHUB_SERVICE_PREFIX:-/}proxy/%PORT%/"
6 changes: 5 additions & 1 deletion images/tensorflow-notebook/cuda/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ LABEL maintainer="Jupyter Project <jupyter@googlegroups.com>"
SHELL ["/bin/bash", "-o", "pipefail", "-c"]

# Install TensorFlow, CUDA and cuDNN with pip
RUN pip install --no-cache-dir "tensorflow[and-cuda]" && \
RUN pip install --no-cache-dir \
"tensorflow[and-cuda]" \
"jupyter-server-proxy" && \
fix-permissions "${CONDA_DIR}" && \
fix-permissions "/home/${NB_USER}"

COPY --chown="${NB_UID}:${NB_GID}" 20tensorboard-proxy-env.sh /usr/local/bin/before-notebook.d/

# workaround for https://github.com/tensorflow/tensorflow/issues/63362
RUN mkdir -p "${CONDA_DIR}/etc/conda/activate.d/" && \
fix-permissions "${CONDA_DIR}"
Expand Down