Skip to content

Conversation

bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Sep 8, 2022

Describe your changes

Add EXPOSE 4040

Issue ticket if applicable

[ENH] - Exposing the Spark UI port #1781

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@bjornjorgensen
Copy link
Contributor Author

shall we add EXPOSE to all others dockerfiles?

@mathbunnyru
Copy link
Member

shall we add EXPOSE to all others dockerfiles?

I don't think so (at least for pyspark). This is the only image where we install pyspark.

@bjornjorgensen
Copy link
Contributor Author

Ok. how about all-spark-notebook then?
https://github.com/jupyter/docker-stacks/blob/main/all-spark-notebook/Dockerfile

@mathbunnyru
Copy link
Member

Ok. how about all-spark-notebook then?
https://github.com/jupyter/docker-stacks/blob/main/all-spark-notebook/Dockerfile

We don't need it there.
Exposed ports are inherited and all-spark is based on pyspark.

I've checked that these ports are inherited by using docker image inspect on both base and minimal images and port 8888/tcp is exposed in both these images (even though we explicitly declare it only in the base image).

@mathbunnyru mathbunnyru merged commit bbe3bbc into jupyter:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants