-
Notifications
You must be signed in to change notification settings - Fork 3k
Do not install python-dev #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jovyan@5daef95157f2:~$ apt-cache depends inkscape | grep python It seems that inkscape depends on python2, but still, if we don't need something to be installed as a direct package, then let's not install it. There is an inkscape bug, that it still needs python2, but it won't be fixed in 20.04. But as soon as 22.04 gets released, the size image will automatically shrink (https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/1735363) |
e7f2dd5
to
7b43439
Compare
@mathbunnyru sorry for the late answer and thank you for taking care of this topic. The test |
Yes, thanks, @romainx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Just pushed the PR #1182 to test nbconvert with inkscape.
Tests are OK without the explicit dependency but as expected python2
is still installed due to inkscape dependency.
$ aptitude why python2
# i inkscape Depends python2:any
# i A python2 Provides python2:any
So as you said I'm Ok to remove this explicit dependency even if it does not bring so much improvements as analyzed in this comment #1083 (comment)
I've asked @parente to review this also in case we missed something.
Thanks for your effort to improve the stacks 👍
Merged the latest master to make sure it still passes all the tests. |
@mathbunnyru, @parente thanks for your help. Let's go for the merge. |
It's an attempt to fix #1083
If everything builds fine, then we probably don't need to install python-dev manually.