Skip to content

Do not install python-dev #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Conversation

mathbunnyru
Copy link
Member

It's an attempt to fix #1083
If everything builds fine, then we probably don't need to install python-dev manually.

@mathbunnyru
Copy link
Member Author

jovyan@5daef95157f2:~$ apt-cache depends inkscape | grep python
Depends: python2:any
python2

It seems that inkscape depends on python2, but still, if we don't need something to be installed as a direct package, then let's not install it.

There is an inkscape bug, that it still needs python2, but it won't be fixed in 20.04. But as soon as 22.04 gets released, the size image will automatically shrink (https://bugs.launchpad.net/ubuntu/+source/inkscape/+bug/1735363)
Or we might delete inkscape.
Or we might use https://launchpad.net/~inkscape.dev/+archive/ubuntu/stable?field.series_filter=focal

@mathbunnyru mathbunnyru force-pushed the asalikhov/remove_py2 branch from e7f2dd5 to 7b43439 Compare July 21, 2020 21:20
@mathbunnyru
Copy link
Member Author

@romainx @parente could you please take a look?

@romainx
Copy link
Collaborator

romainx commented Aug 19, 2020

@mathbunnyru sorry for the late answer and thank you for taking care of this topic.
The reason why inkscape is installed was to fix the issue #243.
In short, inkscape is a dependency of nbconvert to treat SVG in pdf output.
If this seems to be pretty much clear, I don't know exactly when it is required.

The test test_nbconvert.py in minimal-notebook passes without the inkscape dependency installed. However we should extend the test to add a new example file with a plot in order to check if the dependency is needed / work in this condition.
If it's the case, we will probably go further on this PR.
Does that sound reasonable to you?

@mathbunnyru
Copy link
Member Author

Yes, thanks, @romainx.

Copy link
Collaborator

@romainx romainx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Just pushed the PR #1182 to test nbconvert with inkscape.
Tests are OK without the explicit dependency but as expected python2 is still installed due to inkscape dependency.

$ aptitude why python2
# i   inkscape Depends  python2:any
# i A python2  Provides python2:any

So as you said I'm Ok to remove this explicit dependency even if it does not bring so much improvements as analyzed in this comment #1083 (comment)

I've asked @parente to review this also in case we missed something.

Thanks for your effort to improve the stacks 👍

@mathbunnyru
Copy link
Member Author

Merged the latest master to make sure it still passes all the tests.

@romainx
Copy link
Collaborator

romainx commented Nov 8, 2020

@mathbunnyru, @parente thanks for your help. Let's go for the merge.

@romainx romainx merged commit 42f4c82 into jupyter:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we need python-dev?
3 participants