Skip to content

Commit

Permalink
Add 2023 meeting notes
Browse files Browse the repository at this point in the history
  • Loading branch information
isabela-pf committed Aug 17, 2023
1 parent 6654162 commit c8cbc2f
Show file tree
Hide file tree
Showing 18 changed files with 661 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
## January 11, 2023

### Attendees

- Tony
- Gabriel
- Darian
- Isabela
- Mike
- Ryan
- Ely

## Agenda

- Accessible tables with pandas output https://tonyfast.github.io/tonyfast/xxiii/2023-01-02-accessible-dataframes-basic-indexes.html

- Darian: I am reviewing [Stephannie's menubar collapsing PR](https://github.com/jupyterlab/lumino/pull/489)
- darian is review this week.
- it is hard to know the size of something before it is rendered
- completer that measure width https://github.com/jupyterlab/jupyterlab/pull/13663
- Mike:
- should we try to turn on `screenReaderMode` in terminal (xterm.js) or is it fine to keep it off by default
- does anyone has time to provide a review for https://github.com/jupyterlab/lumino/pull/477?
- [jupyterlab # 13704 cell role](https://github.com/jupyterlab/jupyterlab/issues/13704)
- related reading: [aria-label is a code smell](https://ericwbailey.website/published/aria-label-is-a-code-smell/)

## Non-agenda
- What Gabriel is currently working on
- JupyterLab PR: [Make file browser respond to focused elements #13577](https://github.com/jupyterlab/jupyterlab/pull/13577)
- [Tab trap in JupyterLab notebook code cell](https://github.com/Quansight-Labs/jupyter-a11y-mgmt/issues/168)
- post meeting: I believe Darian asked during the meeting if someone had done some a11y testing of Google Colab. I found out later that Balaji Alwar did this, using a public notebook. Result is at https://user-images.githubusercontent.com/2306166/197913587-bbae1601-d0f4-436b-bd83-6d2ea8892753.png.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
## January 25, 2023

### Attendees

| Name | Affiliation | GitHub | Favorite html tag |
| ------------------ | ----------- | ------------- | ------------------------------ |
| tony fast | | @tonyfast | details |
| Tania Allard | Quansight Labs | @trallard | `<abbr>`|
| Stephannie Jimenez Gacha | Quansight Labs | @steff456 | |
| Martha Cryan | IBM | @marthacryan | |
| Gabriel Fouasnon | Quansight Labs | @gabalafou | `<script>` but doing this exercise, I learned about the `<progress>` tag |
| Michal Krassowski | Quansight | @krassowski | |
| Isabela Presedo-Floyd | Quansight Labs | @isabela-pf | `<p>` |
| | | | |

## Agenda

* progress on testing static notebooks. [notebooks for all testing content](https://iota-school.github.io/notebooks-for-all/)
* how we parameterize notebooks with the jupyter configs.
* [rendering dataframes for screen readers with pandas](https://tonyfast.github.io/tonyfast/xxiii/2023-01-02-accessible-dataframes-basic-indexes.html)
* https://adrianroselli.com/2017/11/a-responsive-accessible-table.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
## February 8 2023

### Attendees

| Name | Affiliation | GitHub | Favorite aria role |
| ------------------ | ----------- | ------------- | ------------------------------ |
| tony fast | | @tonyfast | [feed](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/feed_role) |
|william stein | SageMath, Inc | @williamstein | |
| a. t. darian | `quantstack` | @afshin | `complementary` |
| Gabriel Fouasnon | Quansight Labs | @gabalafou | |
| Stephannie Jimenez Gacha | Quansight labs | @steff456 | |
| R Ely | Bloomberg | @ohrely | Olympia (Les Contes d'Hoffmann) |

## Agenda

* [name=Gabriel] Possible office hours question: keyboard shortcuts registered via the JupyterLab command registry are handled on the capture phase, but I have always worked in apps that use bubbling.
* Why are keyboard shortcuts implemented how they are?
* chord shortcuts were applied. it is a emacs feature. helps entice emacs users in jupyter.
* support chords
* css specificity
* people implement their own keyboard action when it is not a command.
* use case: a mini list to make up down l r work.
* How are keyboard shortcuts handled?
* keyboard shortcuts are composed and executed by the command registry.
* this happens at the lumino application layer.
* [specificity versus matchability](https://github.com/jupyterlab/jupyterlab/blob/b7c241483ec8562eb2a836ebc86086d04597aa4a/packages/shortcuts-extension/src/index.ts#L51-L79)
* [name=william] A little motivated by Darian's comment last hour: I'm curious about the accessibility implications of being able to move buttons around in toolbars, reorder menus, etc. It can be confusing because customization has a scope with web apps that is a lot different than say "photoshop".
* [name=tonyfast] semantic tags for notebooks and cells
* Could a [rendered notebook (static HTML page) be described by aria role=feed](https://iota-school.github.io/notebooks-for-all/exports/Imaging_Sky_Background_Estimation-form-based.html)?
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
## February 22 2023

### Attendees

| Name | Affiliation | GitHub | Favorite css property |
| ------------------ | ----------- | ------------- | ------------------------------ |
| tony fast | | @tonyfast | font-size |
| Ryan Lovett | UC Berkeley | @ryanlovett | color |
| Sylvain Corlay | QuantStack | @SylvainCorlay| border-radius |
| Isabela Presedo-Floyd | | | |
| Martha Cryan | | | |
| William Stein | SageMath, Inc| @williamstein| box-shadow d|
| Kseniya Usovich | | |
| R Ely | Bloomberg | @ohrely | all |
| Stephannie Jimenez Gacha | Quansight labs | @steff456 | |

### Agenda

- Isabela
- Update on Space Telescope [user testing](https://github.com/Iota-School/notebooks-for-all/tree/main/user-tests#test-2-content-types). Results for test 2 are a work in progress.
- I am also in the process of lining up JupyterLab-specific user testing. Stay tuned for that!
- Sylvain
- Axe audit announcement & post.
- Draft blog post: https://docs.google.com/document/d/1XpRuWqZVlPRHQzNzfP5K8G2fp6QQS288jP4vjSoWnOU/edit?usp=sharing
- Tony
- UI conventions for error vs warning, etc.
- What if a single Jupyter notebook cell were a form? Motivation: there's a LOT of thought about accessibility of forms...
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
## March 8, 2023

### Attendees

| Name | Affiliation | GitHub |
| ---- | ----------- | ------ |
| tony fast | | @tonyfast |
| Isabela Presedo-Floyd | | |
| William Stein | SageMath | @williamstein |
| Stephannie Jimenez Gacha| Quansight Labs | @steff456 |
| Gabriel Fouasnon | Quansight Labs | @gabalafou |
| R Ely | Bloomberg | @ohrely |
| Blessing Ogoh| |@bl-aire |
| Mike | | @krassowski |

### Agenda

- William: I'm curious if you have any thoughts about what happens when the cursor is at the top (or bottom) of a markdown cell and you hit the up (or down) arrow. It goes to the previous cell instead of "staying in that form element". Is this bad from an accessibility point of view? A user complained today about this behavior to me, prompting [this issue](https://github.com/sagemathinc/cocalc/issues/6526). Same question makes sense for code cells. (Context: could there be a general "accessibility mode" for Jupyter notebook where the entire approach to navigation is much more standard and accessible, but maybe more awkward for experts?)
- User: "I expect arrow keys to only move the cursor in the current form that is being edited."
- [codepen](https://codepen.io/tonyfast/pen/NWLpdrB)
- [WAI](https://www.w3.org/WAI/ARIA/apg/patterns/)
- Where to put accessibility configuration:
- https://github.com/mozilla/readability
- Ely (if time): takeaways from Jupyter for Education Workshop
* what format do professors provide students?
* teaching and sharing formats are often not the same
* export to html is common practice
extensions help and cause problems
* can fix things, but provide more code to be vulnerable to accessibility failings
"slides in latex easier to read"
* used to students saying "give me the source"
* the need for alt text is there, but writing it is hard.
* jupyter is the medium for teaching
- Isabela: Updates on JupyterLab accessibility user research. I'm still in the scheduling phase.
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
## March 22, 2023

### Attendees

| Name | Affiliation | GitHub |
| ---- | ----------- | ------ |
| tony fast | | @tonyfast |
| Ryan Lovett | UC Berkeley | @ryanlovett |
| William Stein | SageMath | @williamstein |
| Stephannie Jimenez| Quansight Labs | @steff456 |
| Gabriel Fouasnon | Quansight Labs | @gabalafou |
| Martha Cryan | IBM | @marthacryan |
| Isabela Presedo-Floyd | Quansight Labs | @isabela-pf |
| Michal Krassowski | | @krassowski |
| Sylvain Corlay | QuantStack | @SylvainCorlay |
| Afshin T. Darian | QuantStack | @afshin |
| Balaji Alwar | UC Berkeley | @balajialg |

### Agenda

- Isabela: Updates!
- JupyterLab accessibility user research. I'm still in the scheduling phase.
- Notebook authoring recommendations.
- STScI test two: content write up is on the horizon.
- Gabriel updates
- [Adding automated Axe-core + Playwright testing to PyData Sphinx Theme](https://github.com/pydata/pydata-sphinx-theme/pull/1260)
- The other big thing I'm working on is trying to find UX bugs in a somewhat high-risk PR I made against JupyterLab to [remove tab traps from the Notebook area](https://github.com/jupyterlab/jupyterlab/pull/14115).
- One big functional change is that browser focus goes on cell wrappers rather than the notebook node itself. This functional change is reflected in a visual change: there is now a bold outline around the notebook cells as you move focus from cell to cell.
- [name=Tony Fast]
- crash course of links of i presented at pycascades https://tonyfast.github.io/tonyfast/xxiii/2023-03-18-pycascades-ally-talk.html
- axecon last week:
- ibm equal access checker ci and extension https://github.com/IBMa/equal-access
- combines multiple web and national standards
- https://www.deque.com/axe-con/sessions/the-accessibility-to-burnout-pipeline/
- thoughts about jupyter accessibility
- cells as forms in lumino
- Sylvain
- More contributions upcoming
- What is a good way to collect the work that's been previously done to stop it from getting lost and to help prioritize?
- Having all the things that have been done collected is too large for the scope of the work coming up.
- Just being responsive should be enough. (Isabela worries about sustaining this but okay.)
- Mike
- [GitHub Copilot X](https://github.blog/2023-03-22-github-copilot-x-the-ai-powered-developer-experience/) (just dropped) got voice control; should I move [jupyterlab-voice-control](https://github.com/krassowski/jupyterlab-voice-control) to jupyterlab-contrib? enabling control via via more modalities would be neat
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
## April 5, 2023

### Attendees

| Name | Affiliation | GitHub |
| ---- | ----------- | ------ |
| A. T. Darian | QuantStack | @afshin |
| Ryan Lovett| UC Berkeley | @ryanlovett |
| Gabriel | Quansight | @gabalafou |
| Ely | Bloomberg | @ohrely |
| Stephannie Jimenez | Quansight | @steff456 |
| Tania | Quansight Labs | @trallard |
| Isabela Presedo-Floyd | Quansight Labs | @isabela-pf |

### Agenda

- Tony: https://github.com/Iota-School/notebooks-for-all/pull/49 shows progress on a semantic html5 structure for notebook webpages. in this approach, we treat the rendered version of the notebook as an entire interactive web page.
- please leave feedback on comments in the pull request
- in this structure
- the notebook occupies the `main` tag
- the each cell is a row in a `table`
- the cell is represented by form components
- this approach surfaces interactive elements like links, forms, and overflowing elements to drive focus. it gives a more meaningful navigation experience of rendered notebooks zoomed in, on a screen, and navigated with tabs.
- this representation could serve as a starting point for the proper roles and aria for interactive implementations to improve their accessible experience.
- Isabela
- Recruiting usability study pariticpants. More information and sign ups at [the Jupyter Discourse topic](https://discourse.jupyter.org/t/participate-in-a-jupyterlab-accessibility-study/18786). Please feel free to share it around.
- [Space Telescope Day of Accessibility registration here](https://iota-school.github.io/day_accessibility/). This is a mostly in-person event with some virtual options.
- Gabriel's updates
- [pydata-sphinx-theme #1260](https://github.com/pydata/pydata-sphinx-theme/pull/1260) - my PR to test PST with Playwright and Axe-core is in final rounds of review, should be close to merging.
- Next steps: expand tests to touch more parts of the theme, fix issues found, integrate with CI
- Hope to close my JupyterLab PRs before next accessibility meeting:
- [jupyterlab #13577](https://github.com/jupyterlab/jupyterlab/pull/13577)
- [jupyterlab #14115](https://github.com/jupyterlab/jupyterlab/pull/14115)
- P
- [GCHQ in UK](https://www.gchq.gov.uk/). Working on accessibility here now! Wahoo! (Isabela wrote the Wahoo!)
- Check out the PR at [jupyterlab/jupyterlab #14320](https://github.com/jupyterlab/jupyterlab/pull/14320).
- ARIA work upcoming
- nick
- [Encouraging Research on Open Knowledge Networks - NSF](https://beta.nsf.gov/funding/opportunities/encouraging-research-open-knowledge-networks)
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
## April 19, 2023

### Attendees

| Name | Affiliation | GitHub |
| ---- | ----------- | ------ |
| A. T. Darian | QuantStack | @afshin |
| Ely R | Bloomberg | @ohrely |
| Stephannie Jimenez Gacha| Quansight Labs | @steff456 |
| Michal Krassowski | | @krassowski |
| Tania | Quansight Labs | @trallard |
| Ryan Lovett | UC Berkeley | @ryanlovett |
| tonyfast | | @tonyfast |
| G. Vidal | ENS de Lyon| @g-vidal|
| Isabela Presedo-Floyd | Quansight Labs | @isabela-pf |
| Balaji Alwar | UC Berkeley | @balajialg |

### Agenda

* turns out there are more guidelines beyond WCAG for authoring tools. <a href="https://www.w3.org/WAI/standards-guidelines/atag/"><abbr title="Authoring Tool Accessibility Guidelines">ATAG</abbr></a> are guidelines specific for accessible authoring experiences. ATAG is part of series of guidelines including WCAG and <a href="https://www.w3.org/WAI/standards-guidelines/uaag/"><abbr title="User Agent Accessibility Guidelines">UAAG</abbr></a>.
* [We haven't talked about these since 2021!](https://github.com/jupyter/accessibility/blob/main/docs/community/meeting-minutes/jupyterlab-accessibility-meetings/all-minutes.md#061621-meeting-minutes)
* Chartability for ensuring that data visualizations, systems, and interfaces are accessible. https://github.com/Chartability/POUR-CAF
* [Do No Harm Guide: Applying Equity Awareness in Data Visualization](https://www.urban.org/research/publication/do-no-harm-guide-applying-equity-awareness-data-visualization)
* Request for a place where we can track/compare different recommendations. Venn diagram-style?
* Interest in having a list of the status of different guidelines. ie. number out of total number guideline compliance per set.
* Isabela was working on a JupyterLab accessibility statement - think keeping that updated to report on effort would be a good step
* Isabela
* Still recruiting usability study participants. More information and sign ups at [the Jupyter Discourse topic](https://discourse.jupyter.org/t/participate-in-a-jupyterlab-accessibility-study/18786). Please feel free to share it around.
* [Draft: notebook authoring checklist](https://github.com/Iota-School/notebooks-for-all/blob/main/resources/event-hackathon/notebook-authoring-checklist.md). This will eventually be submitted to be linked in Jupyter repos as well.
* Gabriel
* Merged :tada: [jupyterlab PR Make file browser respond to focussed elements #13577](https://github.com/jupyterlab/jupyterlab/pull/13577)
* Merged :tada: [pydata-sphinx-theme PR Accessibility test Kitchen Sink with Playwright #1260](https://github.com/pydata/pydata-sphinx-theme/pull/1260)
* follow ups: fixes, expand tests, better reporting
* Not merged but working on today and getting close to taking out of draft mode: [jupyterlab PR Fix tab trap notebook cells #14115](https://github.com/jupyterlab/jupyterlab/pull/14115)
* Preparing for [talk at JupyterCon about automated accessibility testing](https://cfp.jupytercon.com/2023/speaker/YW7ZDA/)
* Stephannie
* Organizing [accessibility docs plan](https://github.com/Quansight-Labs/jupyter-a11y-mgmt/issues/196) - happy to hear thoughts about them
* [Jupyter accessible themes](https://github.com/Quansight-Labs/jupyterlab-accessible-themes)
* Mike
* Long-term planning: idea for [Accessible (and higher-performance) icons #14402](https://github.com/jupyterlab/jupyterlab/issues/14402)
* Good-first issue: [Styled input checkbox focus state is not visible on Ubuntu/Firefox #14354](https://github.com/jupyterlab/jupyterlab/issues/14354)
* Nick
* [NVDA (screen reader) uses robot testing](https://github.com/nvaccess/nvda/blob/master/tests/system/robot/chromeTests.robot). We might benefit from following their lead.
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
## May 3, 2023

### Attendees

| Name | Affiliation | GitHub |
| ---- | ----------- | ------ |
| tonyfast | | @tonyfast |
| Ryan Lovett | UC Berkeley | @ryanlovett |
| Ely | Bloomberg | @ohrely |
| Gabriel | Quansight | @gabalafou |
| Stephannie Jimenez Gacha | Quansight Labs | @steff456 |
| Gérard Vidal | ENS de Lyon| @g-vidal |

### Agenda

* SSC + EC update contents (Ely)
* Quanstack worked toward accessibility testing compliance https://blog.jupyter.org/improving-the-accessibility-of-jupyter-6c695db518d3
* Quansight developed a theming extension with varying accessible themes https://github.com/Quansight-Labs/jupyterlab-accessible-themes - Defines a set of JupyterLab themes compliant to WCAG color standards. Currently we have color blindness friendly themes!
* 400% Zoom audit - some fixes had already been included in both JupyterLab and Lumino
* Notebook 7 audit
* Notebooks for all is a collaboration with the Space Telescope Science Institute that in including disabled people in the testing of Jupyter notebooks and improvements in notebooks accessibility. https://github.com/Iota-School/notebooks-for-all
* [Gabriel] At Quansight Labs, we had an intern working on JupyterLab and accessibility and she wrote a [blog post about her internship](https://labs.quansight.org/blog/zoom-a11y-jupyterlab)
* [Gabriel] Added some accessibility regression tests (tab traps, focus visible), working on making easy-to-use GitHub actions to run accessibility tests, incubating at [Quansight-Labs/jupyter-a11y-testing](https://github.com/Quansight-Labs/jupyter-a11y-testing)
* What is our group's purpose?
* Consistency, fostering advocacy
* What we want to say
* Put accessibility concerns earlier (a11y in the planning phase)
* and consider at every phase of development
* We recognize that this is not simple to scope, but neither is security
* Funding for events to teach developers about accessibility
* What happens if Jupyter fails to close accessibility gaps and ed institutions are forced to not use it?
* Gabriel's update:
* Took a PR out of draft mode that [removes tab traps from the Notebook widget](https://github.com/jupyterlab/jupyterlab/pull/14115)
* On the PR there is a [discussion about how to style focus indicators on the code cell](https://github.com/jupyterlab/jupyterlab/pull/14115#pullrequestreview-1409130132)
* [Tony] https://www.sarasoueidan.com/blog/focus-indicators/
Loading

0 comments on commit c8cbc2f

Please sign in to comment.