Skip to content

moved write function outside of class #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

moved write function outside of class #87

merged 1 commit into from
Feb 23, 2021

Conversation

@staxfur
Copy link
Collaborator

@staxfur staxfur commented Feb 12, 2021

This function moves the write() function outside of the class into the Term:: namespace as disqussed in #81.

@staxfur staxfur requested a review from certik February 12, 2021 23:45
@staxfur staxfur mentioned this pull request Feb 13, 2021
Merged
@certik certik merged commit c847301 into jupyter-xeus:master Feb 23, 2021
@staxfur staxfur deleted the improveWrite branch February 23, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@certik certik certik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staxfur @certik