Skip to content

Conversation

@staxfur
Copy link
Collaborator

@staxfur staxfur commented Aug 23, 2022

This PR updates the window class to handle 24bit / 8bit and 4bit colors in one implementation.

Fixes #128, #96, #107.

WIP: #108.

@staxfur staxfur self-assigned this Aug 23, 2022
@staxfur staxfur added the enhancement New feature or request label Aug 23, 2022
@staxfur staxfur added this to the V1.0.0 milestone Aug 23, 2022
@flagarde
Copy link
Collaborator

Does this is superseded by your new PR?

@staxfur
Copy link
Collaborator Author

staxfur commented Sep 15, 2022

Well #191 implements #190, which isn't covered by this PR, but the whole auto color stuff comes from this PR.

The reason was that this PR gotten a bit over my head, so I rather split it into smaller things so the window class update can be easily merged without having a big mess of different color functions and everything.

So the plan is:

  • Merge Implemented new base.hpp structure #191
  • Apply the new Color functions into a unified Window class version (Currently there is one window class for 4bit and one for 24bit, while the 24bit class doesn't work on macos due to lack of support)
  • Update the 24bit example to use the auto color function
  • Probably also a cleanup and upgrading the Prompt to 24bit colors as well
  • Also the platform header should be pruned and simplified.

@flagarde
Copy link
Collaborator

@MCWertGaming does this PR should be closed ? The platform header should be pruned and simplified. could be solved in other PR (maybe creating an issue for this)

@staxfur
Copy link
Collaborator Author

staxfur commented Jan 1, 2023

Yeah I moved it into #213.

@staxfur staxfur closed this Jan 1, 2023
@staxfur staxfur deleted the window_class branch January 1, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Unify Window and Window_24bit menu_window_24bit does not seem to work on macOS merge window and window_24bit together

2 participants