added y/n prompt

[staxfur]

This PR adds some variations of a y/n style prompt.

Todo:

• unify blocking + non blocking functions
• rename blocking to something else
• use COR
• fix windows compilation

[wolfv]

Looks really good! I left some questions, I hope you don't mind!

[staxfur]

This needs some work anyway - MSVC is going crazy out of nowhere just because I included the base.hpp file that includes the platform.hpp file. I think it's something window.h related again or something... Not sure, if I can fix it that easily for now. We have to remove that include anyway to end stuff like this. But I'd suggest to sinish this PR and merge it until I fixed the windows problem seperately.

[staxfur]

@wolfv do you guys want the prompt to read on non-interactive terminals the input from the stdin? a use case would be:

program | yes # <- send input via standard in

It's already implemented (in theory) in CPP-Terminal, I'd just need to make it available to the prompt function.

[wolfv]

Hmm, good question. I think it woudl be nice, yeah, but most of the time in non-interactive mode we just use --always-yes

[staxfur]

I have tested some fixes for the windows CI in #125 and removing the "platform.hpp" include in the "base.hpp" file fixes all errors (of course that is not a possible fix, as we need it to enable the "raw mode" for capturing input). I'll have to make some bigger changes for fixing this. Originally i planed on fixing that after having the prompt done, but well...

[staxfur]

This PR is now ready @certik @wolfv. Please review it. I have fixed the windows error with a simple undefine for now. It looks ugly, but i'll have to finish the Platform header in order to fix that properly (which will be my next PR). I have moved adding support for reading the choice from stdin to #146.

[staxfur]

I have added CTRL+D support. Can you guys test this PR?

[staxfur]

@certik @wolfv what's the state of this PR?

[staxfur]

It's been almost a month now. Can you review this PR? @certik @wolfv.

[staxfur]

So what's the status of this PR?

[staxfur]

@certik @wolfv

[certik]

Let me review this.

[certik]

It looks fine to me. @wolfv do you think this goes in the right direction? We can always improve upon it once it is merged.

[staxfur]

It has been two weeks now. @wolfv please review.

[staxfur]

What about this PR now? @certik @wolfv I would like to merge the other PRs as well some day.

[certik]

I think that this is fine.

Overall I don't like including windows header files in our header files, they should be included in cpp file only.

I suggest we merge this and iterate on it in master. And if improvements are needed, we can add them in later.

[staxfur]

I think that this is fine.

Overall I don't like including windows header files in our header files, they should be included in cpp file only.

I suggest we merge this and iterate on it in master. And if improvements are needed, we can add them in later.

Yes, I notes that already. The problem with the windows header is that It's needed for saving the terminal state. I think that the right way would be to create a custom struct and then move the old terminal state from the struct defined in windows.h and termio.h into a custom one. what do you think about this? @certik